#2007 - drep_distr rollback error #2010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cmdv
force-pushed
the
2007-rollback-drep_distr
branch
2 times, most recently
from
297586b to
ad5ea9b
Compare
Cmdv
force-pushed
the
2007-rollback-drep_distr
branch
2 times, most recently
from
e7f56b3 to
a1a5e2f
Compare
kderme
reviewed
Oct 30, 2025
| , " WHERE block_no = $1" | ||
| [ "SELECT curr.id, prev.epoch_no" | ||
| , " FROM " <> tableName (Proxy @a) <> " curr" | ||
| , " JOIN " <> tableName (Proxy @a) <> " prev ON prev.block_no = $1 - 1" |
Contributor
There was a problem hiding this comment.
Can this join ever fail, ie having no prev? For example could this query be called when rolling back to genesis?
Contributor
Author
There was a problem hiding this comment.
good question, It would fail if it rolled back to the first block in genesis as it doesn't have a previous block. Do we ever do that?
kderme
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this fixes #2007
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)